build: Use jemalloc on all platforms #2517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using jemalloc on amd64 for a very long time. linkerd2#11430 reports that the proxy's allocation behavior has less desirable characteristics on arm64. To fix this, we adopt use of jemallocator on all platforms. Additionally, we change our dependencies to use tikv-jemallocator. From the docs: > This project is the successor of jemallocator. > > The project is also published as jemallocator for historical > reasons. The two crates are the same except names. For new projects, > it's recommended to use tikv-xxx versions instead.
|
There appear to be problems cross-compling jemalloc with clang. Discarding for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using jemalloc on amd64 for a very long time. linkerd2#11430 reports that the proxy's allocation behavior has less desirable characteristics on arm64. To fix this, we adopt use of jemallocator on all platforms.
Additionally, we change our dependencies to use tikv-jemallocator. From the docs: