Skip to content

Commit

Permalink
review(http/upgrade): remove frivolous Unpin bound
Browse files Browse the repository at this point in the history
https://github.com/linkerd/linkerd2-proxy/pull/3479/files#r1894068885

in `main` this isn't currently pinned, so this was needed to add the `B`
parameter originally in development, but tweaking how we poll the body
(_see lines 70-80, below_) means this bound is indeed frivolous now.

this commit removes an extraneous `Unpin` bound.

Co-authored-by: Scott Fleener <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
  • Loading branch information
cratelyn and sfleen committed Dec 20, 2024
1 parent 0b413a6 commit 039d90b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion linkerd/http/upgrade/src/glue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub struct HyperConnectFuture<F> {

impl<B> Body for UpgradeBody<B>
where
B: Body + Unpin,
B: Body,
B::Error: std::fmt::Display,
{
type Data = B::Data;
Expand Down

0 comments on commit 039d90b

Please sign in to comment.