Include pod UID and container name as optional trace labels #1146
sfleenpr.yml
on: pull_request
Annotations
4 errors and 5 warnings
|
rust:
linkerd/app/src/trace_collector/otel_collector.rs#L21
error: this function has too many arguments (8/7)
--> linkerd/app/src/trace_collector/otel_collector.rs:21:1
|
21 | / pub(super) fn create_collector<S>(
22 | | addr: ControlAddr,
23 | | hostname: Option<String>,
24 | | pod_uid: Option<String>,
... |
29 | | legacy_metrics: metrics::Registry,
30 | | ) -> EnabledCollector
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
|
rust:
linkerd/app/src/trace_collector/otel_collector.rs#L21
error: this function has too many arguments (8/7)
--> linkerd/app/src/trace_collector/otel_collector.rs:21:1
|
21 | / pub(super) fn create_collector<S>(
22 | | addr: ControlAddr,
23 | | hostname: Option<String>,
24 | | pod_uid: Option<String>,
... |
29 | | legacy_metrics: metrics::Registry,
30 | | ) -> EnabledCollector
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
|
|
rust
Process completed with exit code 1.
|
|
ship-it
Process completed with exit code 1.
|
|
meta
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
info
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
rust
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
linkerd-install
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
ship-it
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|