-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration for openhouse-java-iceberg-1.5-runtime and openhouse-spark-3.5-runtime #221
Add integration for openhouse-java-iceberg-1.5-runtime and openhouse-spark-3.5-runtime #221
Conversation
afe2de8
to
cd3d61c
Compare
integrations/java-iceberg-1.5/openhouse-java-itest/build.gradle
Outdated
Show resolved
Hide resolved
...openhouse-java-runtime/src/main/java/com/linkedin/openhouse/javaclient/OpenHouseCatalog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Levi for the PR. Most of this code seem to be duplicated, i've mentioned some tricks to reuse existing code, can we give that a try.
If there were any code changes, could you mark them with a github comment so that its easier to review?
integrations/java-iceberg-1.5/openhouse-java-itest/build.gradle
Outdated
Show resolved
Hide resolved
...java-itest/src/test/java/com/linkedin/openhouse/javaclient/OpenHouseTableOperationsTest.java
Outdated
Show resolved
Hide resolved
integrations/java-iceberg-1.5/openhouse-java-runtime/build.gradle
Outdated
Show resolved
Hide resolved
integrations/java-iceberg-1.5/openhouse-java-runtime/build.gradle
Outdated
Show resolved
Hide resolved
...e-java-runtime/src/main/java/com/linkedin/openhouse/javaclient/OpenHouseMetricsReporter.java
Outdated
Show resolved
Hide resolved
...e-java-runtime/src/main/java/com/linkedin/openhouse/javaclient/OpenHouseTableOperations.java
Outdated
Show resolved
Hide resolved
...s/com/linkedin/openhouse/relocated/org/springframework/http/codec/CodecConfigurer.properties
Outdated
Show resolved
Hide resolved
3237070
to
6050f41
Compare
6050f41
to
af70149
Compare
...tions/spark-3.5/src/main/java/com/linkedin/openhouse/spark/builder/PartitionSpecBuilder.java
Outdated
Show resolved
Hide resolved
integrations/java-iceberg-1.5/openhouse-java-runtime/build.gradle
Outdated
Show resolved
Hide resolved
...-spark-itest/src/test/java/com/linkedin/openhouse/spark/e2e/ddl/CreateTableTestSpark3_5.java
Outdated
Show resolved
Hide resolved
...se-spark-itest/src/test/java/com/linkedin/openhouse/spark/e2e/ddl/DropTableTestSpark3_5.java
Outdated
Show resolved
Hide resolved
I'm working in parallel on implementing this PR's spark3.5 integration via the wondering from the working group here, should I buidl the directory structure and hooks to "old" library in a similar way as this PR? since |
Spark 3.5 gtp image is not ready yet. That's why I didn't upgrade apps. And planning-wise, apps should depend on the spark-3.5-runtime which I'm currently adding, so please hold on a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, looks great @jiang95-dev
integrations/java-iceberg-1.5/openhouse-java-itest/build.gradle
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the current state.
Just wondering if there are future cleanup that's obviously required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jiang95-dev for the changes!
a7ae4c8
a7ae4c8
to
e0e57e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help setup the capability to dismiss a review request? that's by default enabled internally. @sumedhsakdeo
Summary
Adding 3 integration artifacts: openhouse-java-iceberg-1.5-runtime, openhouse-spark-3.5-runtime, and tables-test-fixtures-iceberg-1.5. They are leveraging the iceberg-core:1.5.2 and iceberg-spark-runtime-3.5_2.12, and can only be compiled under Java 9+. This client side upgrade is the step after the server side upgrade, and apps upgrade will be the next step.
Changes
There are no duplicated files after the clean up. Files changed are:
Testing Done
All unit tests and integration tests passed.
Local docker tests:
spark-3.5-base-hadoop3.2.dockerfile
and made local change ofspark-service.yml
for spark tests.Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.