Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(): add vite-react-babel example #1558

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Add example for vite with babel.

While working on that example, found that it complains about requiring js lingui config, because full project is pure esm.
One solution would be just use typescript extension, but also would be good to add processing for cjs config extension.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 4:17PM (UTC)

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (876ba26) 75.38% compared to head (e22abb4) 75.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1558   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files          77       77           
  Lines        1970     1970           
  Branches      516      516           
=======================================
  Hits         1485     1485           
  Misses        374      374           
  Partials      111      111           
Impacted Files Coverage Δ
packages/conf/src/getConfig.ts 86.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.43 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.55 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@andrii-bodnar andrii-bodnar merged commit d98f9dd into lingui:next Mar 23, 2023
@andrii-bodnar andrii-bodnar linked an issue Mar 23, 2023 that may be closed by this pull request
12 tasks
@timofei-iatsenko timofei-iatsenko deleted the vite-example branch March 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples upgrade
2 participants