shaders: Remove workaround for const / let globals
#761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, naga had issues with the correct form for this code, so a workaround was put into place to let the shaders-as-written use `let`, but then turn it into `const`. This hasn't been strictly followed since then with a couple of things using `const` anyway.
|
Take note that a few things were commented out and using hand-written constants but now are using the const to evaluate the value. |
DJMcNab
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, naga had issues with the correct form for this code, so a workaround was put into place to let the shaders-as-written use
let, but then turn it intoconst.This hasn't been strictly followed since then with a couple of things using
constanyway.