Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Rust 1.83 #751

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Update to Rust 1.83 #751

merged 4 commits into from
Nov 29, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Nov 28, 2024

Major changes are some new clippy lints and updates to existing lints.

We don't really use const, which are the other main changes from this release.

waywardmonkeys
waywardmonkeys requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently a "no" on being forced to write code like this with needless_lifetimes. It brings no value that I see.

waywardmonkeys
waywardmonkeys approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to give in on these needless needless_lifetime changes since they're a default in clippy and I can see an argument for them.

But I will be pushing for a reduction in our lint configuration separate from this PR.

@DJMcNab DJMcNab added this pull request to the merge queue Nov 29, 2024
Merged via the queue into linebender:main with commit a603cda Nov 29, 2024
17 checks passed
@DJMcNab DJMcNab deleted the 1.83 branch November 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJMcNab @waywardmonkeys