Spell color consistently as color
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed this due to working on #742. Separated it out rather than folding it into that. Considered putting a thing in |
xorgy
reviewed
Nov 28, 2024
| @@ -60,7 +60,7 @@ pub use snapshot::{ | |||
| pub struct TestParams { | |||
| pub width: u32, | |||
| pub height: u32, | |||
| pub base_colour: Option<Color>, | |||
| pub base_color: Option<Color>, | |||
There was a problem hiding this comment.
Perhaps we could go the other way and introduce more diverse spellings of the word color, instead of stamping them out.
Suggested change
| pub base_color: Option<Color>, | |
| /// La couleur d'arrière-plan, le cas échéant. | |
| pub base_colour: Option<Color>, |
xorgy
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.