Update the CHANGELOG #741
Merged
Update the CHANGELOG #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I would evaluate the CHANGELOG before the next release, I would reach the decision that linebender#740 doesn't need a changelog entry However, @waywardmonkeys believes that it does, so the only viable way for this to end up in the changelog is to do it now
DJMcNab
force-pushed
the
changelog-png
branch
from
4138d35 to
4d64614
Compare
waywardmonkeys
approved these changes
Nov 24, 2024
|
Was going to say it might be nice to reword the commit message, but ah well. |
|
Removing a pr from the merge queue as a reviewer is perfectly fine, fwiw. I don't think this is one which needs to be remediated, but I'm willing to be overruled, and this is a scenario where rewriting history would be feasible (given that nothing builds on top of it). |
|
I'll keep that in mind about removing it in the future. No point in bothering to do a force push or anything, it isn't a big deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I would evaluate the CHANGELOG before the next release, I would reach the decision that #740 doesn't need a changelog entry However, @waywardmonkeys believes that it does, so the only viable way for this to end up in the changelog is to do it now