[test_scenes] Tests scenes for strokes #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armansito
force-pushed
the
pr-stroke-tests
branch
2 times, most recently
from
418d897 to
836a33a
Compare
Added two new test scenes that exercise stroke styles and some edge conditions: 1. stroke_styles: Renders a combination of cap and join styles 2. tricky_strokes: Renders cubic strokes that demonstrate certain edge conditions, such as cusps and co-linear control points. Several of these tests are commented out as they trigger an infinite recursion in the kurbo curve fitting logic and crash the example. These should probably get copied as unit tests in kurbo as part of a fix for the infinite recursions.
armansito
force-pushed
the
pr-stroke-tests
branch
from
836a33a to
adcb50b
Compare
raphlinus
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Useful cases, thanks!
All the broken_cubic cases are fixed by kurbo#318, and I've included those in a test. Additionally, the artifact that appears is a numerical robustness issue that was fixed in msaa fine but not yet ported to the area aa. This can be done as an isolated patch, but I'm also tempted to switch the segment storage from 24 to 8 bytes and fold the change into that; the msaa is already written in that style and does not read the y_edge value, so making that change would get rid of some duplicated logic overlapping the robustness concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new test scenes that exercise stroke styles and some edge conditions:
stroke_styles: Renders a combination of cap and join styles
tricky_strokes: Renders cubic strokes that demonstrate certain edge conditions, such as cusps and co-linear control points. Several of these tests are commented out as they trigger an infinite recursion in the kurbo curve fitting logic and crash the example.
These should probably get copied as unit tests in kurbo as part of a fix for the infinite recursions.