Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Kaur Kuut <[email protected]>
  • Loading branch information
DJMcNab and xStrom authored Nov 27, 2024
1 parent 582a090 commit 1ff851b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
16 changes: 1 addition & 15 deletions vello/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
// The following lints are part of the Linebender standard set,
// but resolving them has been deferred for now.
// Feel free to send a PR that solves one or more of these.
// Allow because of: https://github.com/rust-lang/rust/pull/130025
// Need to allow instead of expect until Rust 1.83 https://github.com/rust-lang/rust/pull/130025
#![allow(missing_docs, reason = "We have many as-yet undocumented items.")]
#![expect(
missing_debug_implementations,
Expand All @@ -114,23 +114,9 @@
reason = "Deferred"
)]
#![allow(
// missing_debug_implementations,
// elided_lifetimes_in_paths,
// single_use_lifetimes,
// unnameable_types,
// unreachable_pub,
// clippy::return_self_not_must_use,
// clippy::cast_possible_truncation,
// clippy::missing_assert_message,
// clippy::shadow_unrelated,
// clippy::missing_panics_doc,
clippy::missing_errors_doc,
// clippy::exhaustive_enums,
clippy::todo,
// clippy::print_stderr,
clippy::partial_pub_fields,
// clippy::use_self,
// clippy::match_same_arms,
reason = "Deferred, only apply in some feature sets so not expect"
)]

Expand Down
2 changes: 1 addition & 1 deletion vello_encoding/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// The following lints are part of the Linebender standard set,
// but resolving them has been deferred for now.
// Feel free to send a PR that solves one or more of these.
// Allow because of: https://github.com/rust-lang/rust/pull/130025
// Need to allow instead of expect until Rust 1.83 https://github.com/rust-lang/rust/pull/130025
#![allow(missing_docs, reason = "We have many as-yet undocumented items.")]
#![expect(
missing_debug_implementations,
Expand Down
2 changes: 1 addition & 1 deletion vello_shaders/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// The following lints are part of the Linebender standard set,
// but resolving them has been deferred for now.
// Feel free to send a PR that solves one or more of these.
// Allow because of: https://github.com/rust-lang/rust/pull/130025
// Need to allow instead of expect until Rust 1.83 https://github.com/rust-lang/rust/pull/130025
#![allow(missing_docs, reason = "We have many as-yet undocumented items.")]
#![expect(
missing_debug_implementations,
Expand Down

0 comments on commit 1ff851b

Please sign in to comment.