Update to Rust 2021 edition, add no_std support
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update to 2021 stops the dev dependencies from interfering with the features enabled in `log`, breaking `no_std` builds within the repository.
DJMcNab
approved these changes
Nov 13, 2024
| @@ -126,6 +130,7 @@ impl fmt::Display for Error { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
| impl std::error::Error for Error {} | |||
There was a problem hiding this comment.
:(
Only need to wait two more years for core::error::Error at this pace of MSRV growth
| @@ -27,10 +27,14 @@ Since it's very simple we will start with limitations: | |||
| */ | |||
|
|
|||
| #![doc(html_root_url = "https://docs.rs/simplecss/0.2.1")] | |||
There was a problem hiding this comment.
This seems suspect, but isn't needed to be fixed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to 2021 stops the dev dependencies from interfering with the features enabled in
log, breakingno_stdbuilds within the repository.