Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust stable to 1.82 and satisfy Clippy. #2409

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Update Rust stable to 1.82 and satisfy Clippy. #2409

merged 6 commits into from
Oct 22, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Oct 22, 2024

Contains one API change:

--- pub struct CustomCursor(Arc<HCursor>);
+++ pub struct CustomCursor(Rc<HCursor>);

@xStrom xStrom added the maintenance cleans up code or docs label Oct 22, 2024
@xStrom xStrom marked this pull request as ready for review October 22, 2024 12:03
@xStrom xStrom added the S-needs-review waits for review label Oct 22, 2024
@xStrom xStrom added this pull request to the merge queue Oct 22, 2024
Merged via the queue into linebender:master with commit 49b5352 Oct 22, 2024
12 checks passed
@xStrom xStrom deleted the rust182 branch October 22, 2024 13:36
jaredoconnell
jaredoconnell approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and I can validate that there are no problems running basic examples on MacOS.

@xStrom xStrom added this to the Release 0.9 milestone Oct 25, 2024
@xStrom xStrom removed the S-needs-review waits for review label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
maintenance cleans up code or docs
Projects
None yet
Milestone
Release 0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@xStrom @waywardmonkeys @jaredoconnell