Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable trivially_copy_pass_by_ref clippy lint. #1048

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Enable trivially_copy_pass_by_ref clippy lint. #1048

merged 2 commits into from
Jun 20, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Jun 19, 2020

Rust 1.44 moved the trivially_copy_pass_by_ref clippy lint to pedantic. As discussed on zulip let's turn it back on, at least for now.

This PR also fixes the corresponding error in relation to the recent Scale rework.

@xStrom xStrom added the S-needs-review waits for review label Jun 19, 2020
luleyleo
luleyleo approved these changes Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Maybe we could use a clippy.toml file to set the same config for all our crates?

@luleyleo luleyleo removed the S-needs-review waits for review label Jun 20, 2020
@xStrom
Copy link
Member Author

xStrom commented Jun 20, 2020

Unfortunately for some bizarre reason they have decided that clippy.toml should not have the power to enable/disable lints. There is some movement to have this feature in Cargo.toml but it doesn't look like it'll arrive any time soon.

@xStrom xStrom merged commit 0cccdd1 into linebender:master Jun 20, 2020
@xStrom xStrom deleted the scale-copy branch June 20, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xStrom @luleyleo