Remove GUEST write permission #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A public repository in GitHub grants READ permission to normal users but does not give WRITE permission to them. Similarly, I don't think it is not make sense to grant a `WRITE` permission to `GUEST` role in Central Dogma. Related: line#1048 Modifications: - Disallow setting the GUEST WRITE permssion in the repo role UI. - The old WRITE permission of GUEST is automatically converted to READ permission. - I will write a migration to clean the GUEST WRITE permission data stored in `metadata.json` later. Because two role formats are fixed in `metadata.json` and I don't think the new format is stabilized. The new format could be changed when adding a new permission feature. - Breaking) GUEST users no longer write a change to a repository. A MEMBER WRITE role is explicitly necessary. Result: The GUEST WRITE permission is remove from the repository roles.
jrhee17
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A public repository in GitHub grants READ permission to normal users but does not give WRITE permission to them. Similarly, it does not make sense to grant a
WRITEpermission toGUESTrole in Central Dogma.Related: #1048
Modifications:
metadata.jsonlater. Because two role formats are fixed inmetadata.jsonand I don't think the new format is stabilized. The new format could be changed when a new permission feature is added.Result:
The GUEST WRITE permission is removed from the repository roles.