Skip to content

Commit

Permalink
Merge branch 'develop' into fix/form-errors
Browse files Browse the repository at this point in the history
  • Loading branch information
raclim authored Nov 13, 2023
2 parents e0754db + 7907672 commit 858c92d
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 32 deletions.
19 changes: 2 additions & 17 deletions client/images/p5js-logo-small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 1 addition & 3 deletions client/modules/IDE/actions/project.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,7 @@ export function resetProject() {
}

export function newProject() {
setTimeout(() => {
browserHistory.push('/');
}, 0);
browserHistory.push('/', { confirmed: true });
return resetProject();
}

Expand Down
3 changes: 2 additions & 1 deletion client/modules/IDE/pages/IDEView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ function WarnIfUnsavedChanges() {
isAuth(nextLocation.pathname) ||
isAuth(currentLocation.pathname) ||
isOverlay(nextLocation.pathname) ||
isOverlay(currentLocation.pathname)
isOverlay(currentLocation.pathname) ||
nextLocation.state?.confirmed
) {
return true; // allow navigation
}
Expand Down
1 change: 1 addition & 0 deletions client/modules/Legal/components/PolicyContainer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { remSize, prop } from '../../../theme';

const PolicyContainerMain = styled.main`
max-width: ${remSize(700)};
min-height: 100vh;
margin: 0 auto;
padding: ${remSize(10)};
line-height: 1.5em;
Expand Down
2 changes: 1 addition & 1 deletion client/styles/components/_editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ pre.CodeMirror-line {
margin-left: 0;
}

// z-index: 20;
z-index: 1;

width: 580px;
font-family: Montserrat, sans-serif;
Expand Down
17 changes: 11 additions & 6 deletions client/styles/components/_nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -162,21 +162,26 @@
position: absolute;
}
}
.svg__logo g > path {

.svg__logo {

@include themify() {
fill: getThemifyVariable('logo-color');
// Set background color of the logo
background-color: getThemifyVariable('logo-color');
}
}
.svg__logo g g:first-of-type path {
fill: none;

}

.svg__logo g g:first-of-type use {
.svg__logo g path{

@include themify() {
// Set internal color of the logo;
fill: getThemifyVariable('logo-background-color');
}

}


.nav__keyboard-shortcut {
font-size: #{12 / $base-font-size}rem;
font-family: Inconsololata, monospace;
Expand Down
4 changes: 4 additions & 0 deletions client/styles/components/_toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,12 @@
}

.toolbar__autorefresh-label {
cursor: pointer;
@include themify() {
color: getThemifyVariable('secondary-text-color');
&:hover {
color: getThemifyVariable('logo-color');
}
}
margin-left: #{5 / $base-font-size}rem;
font-size: #{12 / $base-font-size}rem;
Expand Down
16 changes: 12 additions & 4 deletions client/utils/codemirror-search.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,24 @@ function persistentDialog(cm, text, deflt, onEnter, replaceOpened, onKeyDown) {

var upArrow = dialog.getElementsByClassName("up-arrow")[0];
CodeMirror.on(upArrow, "click", function () {
cm.focus();
CodeMirror.commands.findPrev(cm);
searchField.blur();
if (searchField.value.trim() === "") {
searchField.focus();
} else {
cm.focus();
CodeMirror.commands.findPrev(cm);
searchField.blur();
}
});

var downArrow = dialog.getElementsByClassName("down-arrow")[0];
CodeMirror.on(downArrow, "click", function () {
if (searchField.value.trim() === "") {
searchField.focus();
}else{
cm.focus();
CodeMirror.commands.findNext(cm);
searchField.blur();
}
});

var regexpButton = dialog.getElementsByClassName("CodeMirror-regexp-button")[0];
Expand Down Expand Up @@ -371,7 +379,7 @@ function doSearch(cm, rev, persistent, immediate, ignoreQuery) {
startSearch(cm, state, q);
findNext(cm, rev);
}
} else {
} else {
dialog(cm, queryDialog, 'Search for:', q, function (query) {
if (query && !state.query)
cm.operation(function () {
Expand Down

0 comments on commit 858c92d

Please sign in to comment.