-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FunctionNode and basic cosmology #33
Conversation
Fix the distance kind as "luminosity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, than k you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This is a relatively substantial PR that changes how the TDAstro DAG works in a few import ways:
ParameterizedNode
s have a clearer list of what type of setters they accept and cleaner logic to determine which type to use.FunctionNode
class to the evaluation DAG that allows users to wrap a function, such as random number generation or cosmology computation. TheFunctionNode
is based off theParameterizedNode
so that it keeps sampling in sync when evaluating the function.