Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap sncosmo models #26

Closed
wants to merge 2 commits into from
Closed

Wrap sncosmo models #26

wants to merge 2 commits into from

Conversation

jeremykubica
Copy link
Contributor

This PR does two things:

  1. Wrap all the sncosmo models in a PhysicalModel that can be used in our flow. This implementation will be a slower due to levels of indirection, but will provide access to the library for anything we haven't implemented natively.
  2. Add the ability to change the parameter setting for a PhysicalModel. This is needed to provide compatibility with sncosmo's set() function.

@jeremykubica jeremykubica requested review from hombit and mi-dai July 11, 2024 15:23
@jeremykubica
Copy link
Contributor Author

Closing to break this into two. #27 is the first half of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant