Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to read in files in grid format #25

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add a function to read in files in grid format #25

merged 3 commits into from
Jul 12, 2024

Conversation

jeremykubica
Copy link
Contributor

As a precursor to being able to load SALT2 and SALT3 models, we need to be able to read in the input files. This PR adds functionality to read in files in the same format the sncosmo uses (although uses astropy tables to read them instead of manually reading the files).

@jeremykubica jeremykubica requested a review from hombit July 10, 2024 22:33
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I'm not sure how general these tools should be and what scope should they have. If we are focused to load sncosmo-like data only, I'd ask @mi-dai to review it

@jeremykubica jeremykubica requested a review from mi-dai July 11, 2024 15:40
Copy link
Contributor

@mi-dai mi-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if this is only for reading SALT2/3 model files or other files with the same format.

@jeremykubica jeremykubica merged commit 9b287e0 into main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants