Expand the DAG resampling #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliviaLynn
approved these changes
Jul 9, 2024
| @@ -123,28 +125,28 @@ def sample_parameters(self, max_depth=50, **kwargs): | |||
| raise ValueError(f"Maximum sampling depth exceeded at {self}. Potential infinite loop.") | |||
|
|
|||
| # Run through each parameter and sample it based on the given recipe. | |||
| for param, value in self.setters.items(): | |||
| for name, source_type, setter in self.setters: | |||
There was a problem hiding this comment.
I especially like how this block turned out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to improve how the parameter sampling works:
EffectModelcan have and resample functional parameters.