Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small clean ups to node naming and data storage #174

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

jeremykubica
Copy link
Contributor

Simplify some of the aspects of the ParameterizedNode:

  1. Don't precompute and store direct_dependencies as it is only used in a single place.
  2. Change default node string from "pos:class_name" to "class_name_pos"
  3. Simplify extra_tag logic that FunctionNode was using to include the function name. Instead FunctionNode just generates the new name and passes that along.

Copy link

Before [745e20c] After [b23c19e] Ratio Benchmark (Parameter)
1.92±1ms 2.02±2ms 1.05 benchmarks.TimeSuite.time_fnu_to_flam
1.35±0.1ms 1.40±0.08ms 1.04 benchmarks.TimeSuite.time_apply_passbands
9.47±1ms 9.81±2ms 1.04 benchmarks.TimeSuite.time_evaluate_salt3_model
15.6±0.3μs 15.7±0.2μs 1.01 benchmarks.TimeSuite.time_sample_x1_from_hostmass
8.79±0.03ms 8.83±0.07ms 1 benchmarks.TimeSuite.time_load_passbands
1.34±0.01s 1.35±0.01s 1 benchmarks.TimeSuite.time_make_x1_from_hostmass
4.36±1ms 4.33±1ms 0.99 benchmarks.TimeSuite.time_chained_evaluate
121±1μs 120±2μs 0.99 benchmarks.TimeSuite.time_sample_x0_from_distmod
5.48±0.4ms 5.31±0.2ms 0.97 benchmarks.TimeSuite.time_evaluate_salt3_passbands
31.4±0.2μs 27.1±0.4μs 0.86 benchmarks.TimeSuite.time_make_new_salt3_model

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 7104eb1 into main Oct 18, 2024
5 checks passed
@jeremykubica jeremykubica deleted the node_naming branch October 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants