Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper function for auto-applying colmap #173

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Helper function for auto-applying colmap #173

merged 1 commit into from
Oct 16, 2024

Conversation

jeremykubica
Copy link
Contributor

The user should not need to know about the colmap in OpSim. This provides a quick check that will auto-apply the colmap if it is present and has the correct mapping.

@jeremykubica jeremykubica requested a review from hombit October 16, 2024 12:24
Copy link

Before [97d9ca6] After [f508841] Ratio Benchmark (Parameter)
1.46±0.9ms 1.26±0.1ms ~0.87 benchmarks.TimeSuite.time_fnu_to_flam
8.58±0.05ms 8.63±0.06ms 1.01 benchmarks.TimeSuite.time_load_passbands
126±0.9μs 128±2μs 1.01 benchmarks.TimeSuite.time_sample_x0_from_distmod
1.42±0.01s 1.42±0.01s 1.00 benchmarks.TimeSuite.time_make_x1_from_hostmass
16.7±0.2μs 16.7±0.7μs 1.00 benchmarks.TimeSuite.time_sample_x1_from_hostmass
4.36±1ms 4.32±1ms 0.99 benchmarks.TimeSuite.time_chained_evaluate
32.8±0.3μs 32.1±0.5μs 0.98 benchmarks.TimeSuite.time_make_new_salt3_model
1.41±0.1ms 1.36±0.08ms 0.97 benchmarks.TimeSuite.time_apply_passbands
9.23±0.9ms 8.91±0.8ms 0.97 benchmarks.TimeSuite.time_evaluate_salt3_model
5.36±0.3ms 5.13±0.1ms 0.96 benchmarks.TimeSuite.time_evaluate_salt3_passbands

Click here to view all benchmarks.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jeremykubica jeremykubica merged commit 745e20c into main Oct 16, 2024
5 checks passed
@jeremykubica jeremykubica deleted the auto_colmap branch October 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants