Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper node for testing #163

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add a helper node for testing #163

merged 4 commits into from
Oct 18, 2024

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Oct 14, 2024

While I was testing #162, I wanted a node where I could manually specify which values to return. This provides that and will hopefully make future tests easier to write.

I also renamed the rand_nodes directory to math_nodes for clarity and moved the SingleValueNode there (from base_models.py)

Copy link

github-actions bot commented Oct 14, 2024

Before [745e20c] After [daf633a] Ratio Benchmark (Parameter)
failed 1.54±0.1ms n/a benchmarks.TimeSuite.time_apply_passbands
failed 4.65±1ms n/a benchmarks.TimeSuite.time_chained_evaluate
failed 10.4±2ms n/a benchmarks.TimeSuite.time_evaluate_salt3_model
failed 5.57±0.4ms n/a benchmarks.TimeSuite.time_evaluate_salt3_passbands
failed 1.99±1ms n/a benchmarks.TimeSuite.time_fnu_to_flam
failed 9.11±0.1ms n/a benchmarks.TimeSuite.time_load_passbands
failed 32.0±0.2μs n/a benchmarks.TimeSuite.time_make_new_salt3_model
failed 1.35±0.02s n/a benchmarks.TimeSuite.time_make_x1_from_hostmass
failed 125±2μs n/a benchmarks.TimeSuite.time_sample_x0_from_distmod
failed 15.9±0.2μs n/a benchmarks.TimeSuite.time_sample_x1_from_hostmass

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 7121cf6 into main Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants