Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passband optimization: store wave indices in each Passband #120

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Passband optimization: store wave indices in each Passband #120

merged 3 commits into from
Sep 24, 2024

Conversation

OliviaLynn
Copy link
Member

Described in and closes #112:

When calling fluxes_to_bandfluxes, we recalculate the portion of PassbandGroup.waves that overlaps with each individual Passband's waves. This could be done ahead of time and stored to make fluxes_to_bandfluxes faster (and recalculated each time the transmission table is re-gridded).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Before [f05b611] After [f70e55b] Ratio Benchmark (Parameter)
7.04±0.1ms 7.02±0.02ms 1 benchmarks.time_chained_evaluate
1.23±0.02s 1.23±0.01s 1 benchmarks.time_x1_from_hostmass

Click here to view all benchmarks.

@OliviaLynn OliviaLynn marked this pull request as ready for review September 24, 2024 15:26
@OliviaLynn OliviaLynn merged commit 27c8c7e into main Sep 24, 2024
6 checks passed
@OliviaLynn OliviaLynn deleted the issue/112/passband-optimization branch September 24, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremykubica jeremykubica jeremykubica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passband optimization
2 participants
@OliviaLynn @jeremykubica