Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An initial framework for sources #1

Merged
merged 7 commits into from
Jun 21, 2024
Merged

An initial framework for sources #1

merged 7 commits into from
Jun 21, 2024

Conversation

jeremykubica
Copy link
Contributor

Puts a minimal framework together for sources and effects.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@jeremykubica jeremykubica requested a review from OliviaLynn June 21, 2024 15:57
OliviaLynn
OliviaLynn approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@OliviaLynn OliviaLynn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Oh, wait -- maybe the unit tests. One sec.

@jeremykubica jeremykubica requested a review from OliviaLynn June 21, 2024 16:30
@jeremykubica jeremykubica merged commit 3c83d1c into main Jun 21, 2024
4 checks passed
@jeremykubica jeremykubica deleted the jeremys_proposal branch June 21, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliviaLynn OliviaLynn OliviaLynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @OliviaLynn