-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin dask-expr to < 1.10.11 and revert "Add support for running batch on a single lightcurve" #433
Conversation
This reverts commit 89aa116.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 95.84% 95.82% -0.03%
==========================================
Files 25 25
Lines 1781 1771 -10
==========================================
- Hits 1707 1697 -10
Misses 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this. Did you try playing with the dask version itself at all? Their test suite is failing atm, and I wonder if pinned dask itself to something older would stabilize things
I've messed around a bit, but among the compatible dask versions, I didn't see the error disappear. But probably worth checking again |
Reverts #420 and pins dask-expr <1.0.11 to address flakiness reported in #434. The plan is to do another PR for the batch single_lc changes in #420 after all of the batch-related flakiness has been addressed.
Note that even with these changes we're still seeing the test_batch_by_band errors referenced in lincc-frameworks/tape#434 consistently on the python 3.11.9 build, but this is still an improvement over the current test failures we've been seeing in #427