Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slow timing comparsion #425

Merged
merged 2 commits into from
Apr 4, 2024
Merged

remove slow timing comparsion #425

merged 2 commits into from
Apr 4, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Apr 4, 2024

The timing comparison takes >5 minutes to build here, making it a disproportionate amount of the doc build time. We've seen timing to be more workflow dependent, so it seems best to just have users test ray if it's interesting to them and let them see the results for themselves.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dougbrn dougbrn marked this pull request as ready for review April 4, 2024 18:12
Copy link

github-actions bot commented Apr 4, 2024

Before [bac4fe7] After [7d241f6] Ratio Benchmark (Parameter)
32.7±0.5ms 32.9±0.2ms 1.01 benchmarks.time_batch
33.7±0.4ms 34.1±0.2ms 1.01 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (bac4fe7) to head (febcac6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          25       25           
  Lines        1755     1755           
=======================================
  Hits         1681     1681           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn requested a review from wilsonbb April 4, 2024 18:20
@dougbrn dougbrn merged commit 73199ac into main Apr 4, 2024
10 checks passed
@dougbrn dougbrn deleted the remove_timing_comparison branch April 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants