Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force flag to calc_nobs repartitioning #413

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Mar 28, 2024

Change Description

Resolves #405.

  • My PR includes a link to the issue that I am addressing

Solution Description

All this needed was the force=True flag to allow light partition expansion when the boundaries don't overlap completely.

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Before [750fe4b] <v0.4.0> After [4f46bcd] Ratio Benchmark (Parameter)
33.9±0.4ms 35.5±1ms 1.05 benchmarks.time_prune_sync_workflow
32.5±0.6ms 33.1±0.4ms 1.02 benchmarks.time_batch

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (750fe4b) to head (fffa3f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          25       25           
  Lines        1751     1751           
=======================================
  Hits         1677     1677           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review March 28, 2024 17:36
@dougbrn dougbrn requested a review from wilsonbb March 28, 2024 17:37
@dougbrn dougbrn merged commit 19ff5ad into main Mar 28, 2024
10 checks passed
@dougbrn dougbrn deleted the fix_calc_nobs_divisions branch April 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with calc_nobs implicit repartitioning
2 participants