Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EnsembleFrame.repartition #349

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix EnsembleFrame.repartition #349

merged 3 commits into from
Jan 17, 2024

Conversation

wilsonbb
Copy link
Collaborator

@wilsonbb wilsonbb commented Jan 17, 2024

Change Description

EnsembleFrame now extends Dask's DataFrame.repartition to ensure that Ensemble-related metadata is propagated. This closes #342

I also replace a call to

self.source = self.source.repartition(...)

with

self.update_frame(self.source.repartition(...) to ensure that all frame-related tracking data is updated.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

github-actions bot commented Jan 17, 2024

Before [f69be16] After [7b8fe0d] Ratio Benchmark (Parameter)
38.7±0.2ms 39.3±0.5ms 1.01 benchmarks.time_batch
42.7±0.8ms 42.0±0.3ms 0.98 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f69be16) 95.15% compared to head (2a2c272) 95.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files          24       24           
  Lines        1631     1634    +3     
=======================================
+ Hits         1552     1555    +3     
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilsonbb wilsonbb changed the title Repartitioning Fix EnsembleFrame.repartition Jan 17, 2024
@wilsonbb wilsonbb requested a review from dougbrn January 17, 2024 01:29
@wilsonbb wilsonbb marked this pull request as ready for review January 17, 2024 01:29
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good!

@wilsonbb wilsonbb merged commit f4109c6 into main Jan 17, 2024
13 checks passed
@dougbrn dougbrn deleted the repartitioning branch April 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tape.EnsembleFrame Repartition Doesn't Track Parent Ensemble
2 participants