Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version #302

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add version #302

merged 2 commits into from
Nov 29, 2023

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Nov 29, 2023

Addresses #137, looks like we were just missing the one line in the init, as setuptools already dynamically generates a _version.py file.

(Should be completely non-conflicting with the refactor)

@dougbrn dougbrn marked this pull request as ready for review November 29, 2023 19:59
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d97c55) 94.02% compared to head (5984bdd) 94.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   94.02%   94.03%           
=======================================
  Files          23       23           
  Lines        1206     1207    +1     
=======================================
+ Hits         1134     1135    +1     
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn requested a review from wilsonbb November 29, 2023 20:04
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small but very helpful change!

@dougbrn dougbrn merged commit 6f85220 into main Nov 29, 2023
10 checks passed
@dougbrn dougbrn mentioned this pull request Nov 29, 2023
@dougbrn dougbrn deleted the add_version branch December 11, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants