Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing unit test #265

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

wenneman
Copy link
Collaborator

@wenneman wenneman commented Oct 6, 2023

Removed reference to Ensemble._nobs_band_cols field

Ensemble._nobs_band_cols field
@wenneman wenneman self-assigned this Oct 6, 2023
@wenneman wenneman linked an issue Oct 6, 2023 that may be closed by this pull request
@wenneman wenneman requested a review from drewoldag October 6, 2023 20:36
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a93408) 93.60% compared to head (8d65f23) 93.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   93.60%   93.78%   +0.17%     
==========================================
  Files          22       23       +1     
  Lines        1142     1174      +32     
==========================================
+ Hits         1069     1101      +32     
  Misses         73       73              
Files Coverage Δ
src/tape/__init__.py 100.00% <100.00%> (ø)
src/tape/ensemble.py 92.00% <ø> (ø)
src/tape/ensemble_readers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@wenneman wenneman merged commit a81f2a4 into main Oct 6, 2023
9 checks passed
@wenneman wenneman deleted the issue/263/unit-test-failing-after-pr-256 branch October 6, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test failing after PR #256
2 participants