Make ensemble's object and source fields public

[wilsonbb]

Make Ensemble._source and Ensemble._object public fields (Ensemble.source and Ensemble.object respectively).

As this is simply a renaming, no new testing is added.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Patch coverage: 81.25% and no project coverage change.

Comparison is base (7561df3) 92.63% compared to head (f6e1f4d) 92.63%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files          22       22           
  Lines        1140     1140           
=======================================
  Hits         1056     1056           
  Misses         84       84           

Files Changed	Coverage Δ
src/tape/ensemble.py	89.64% <81.25%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wilsonbb]

@hombit I have also added you a reviewer to give you a way to signal whether you are ready to break the current API with this change.

[hombit]

Looks good to me! The only discussion point I have is protection of .source/.object attributes from being accidentally re-assigned by user with ens.source = something. We can make it work using "defensive shallow copy" pattern (I'm pretty sure that it has a better name =)

class Ensemble:
    _object
    @property
    def object(self):
        # Will Dask make a shallow copy here? Could we make it read-only?
        return object.copy()

[hombit]

It actually doesn't solve #214, because that one was about ._time_col, ._flux_col, etc

[dougbrn]

looks good to me!

[dougbrn]

We'll get this from the refactor, correct? Is there a need to keep this open @wilsonbb ?

[wilsonbb]

We'll get this from the refactor, correct? Is there a need to keep this open @wilsonbb ?

Yeah this is correct, closing.