This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Ensembles can now track a group of labeled frames #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbrn
approved these changes
Aug 31, 2023
| raise ValueError( | ||
| f"Unable to update frame with no populated `EnsembleFrame.label`." | ||
| ) | ||
| if frame.label == SOURCE_FRAME_LABEL or frame.label == OBJECT_FRAME_LABEL: |
There was a problem hiding this comment.
In the future, we will probably want to update this to check if the frame to be updated is an instance of an ObjectFrame or SourceFrame, we may want to allow users to update in that case.
There was a problem hiding this comment.
Yeah, that makes sense to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides methods for an
Ensembleto trackEnsembleFrames(a subclass of Dask Dataframes), supporting functionality to add, update, drop, select, and print info about the frames.Each
EnsembleFrameobject is tracked by a user-provided string label. However "source" and "object" are reserved labels for the respective source and object tables. Though these are not currently populated by theEnsembleloader functions, we go ahead and prevent the user from adding, updating, or removing frames tracked with those reserved labels.This functionality was proposed in issue #193.