Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minimal Dask Dataframe subclass for the Ensemble #209

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

wilsonbb
Copy link
Collaborator

Introduces the EnsembleFrame, a minimal subclass extending the Dask Dataframe as proposed in issue #192. A barebones EnsembleSeries is included as well.

In order to correctly propagate the metadata that Dask uses when instantiating dataframes, the TapeFrame and TapeSeries Pandas subclasses are provided as well.

Note that dask-geopandas was used as a model extending the Dask dataframe.

@wilsonbb wilsonbb requested a review from dougbrn August 25, 2023 22:46
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good! I made a few comments, most pointed at the unit tests encouraging the creation and use of fixtures in conftest.py.

src/tape/ensemble_frame.py Outdated Show resolved Hide resolved
tests/tape_tests/test_ensemble_frame.py Outdated Show resolved Hide resolved
tests/tape_tests/test_ensemble_frame.py Outdated Show resolved Hide resolved
tests/tape_tests/test_ensemble_frame.py Outdated Show resolved Hide resolved
src/tape/ensemble_frame.py Outdated Show resolved Hide resolved
@wilsonbb wilsonbb requested a review from dougbrn August 28, 2023 21:49
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good feel free to merge.

@wilsonbb wilsonbb merged commit d033607 into tape_ensemble_refactor Aug 28, 2023
@wilsonbb wilsonbb linked an issue Aug 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnsembleFrame Refactor Milestone 1: EnsembleFrame Class Creation
2 participants