Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower level tutorial notebook #71

Merged
merged 3 commits into from
May 9, 2024
Merged

Lower level tutorial notebook #71

merged 3 commits into from
May 9, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 9, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented May 9, 2024

Before [88c2aee] After [e6daf76] Ratio Benchmark (Parameter)
6.53±0.2ms 6.80±0.1ms 1.04 benchmarks.NestedFrameQuery.time_run
63.8±3ms 65.4±3ms 1.02 benchmarks.ReassignHalfOfNestedSeries.time_run
5.40±0.03ms 5.44±0.07ms 1.01 benchmarks.NestedFrameReduce.time_run
34.8±2ms 34.9±2ms 1 benchmarks.AssignSingleDfToNestedSeries.time_run
86M 85.8M 1 benchmarks.NestedFrameAddNested.peakmem_run
88.2M 88.1M 1 benchmarks.NestedFrameQuery.peakmem_run
88.2M 88.1M 1 benchmarks.NestedFrameReduce.peakmem_run
257M 255M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
8.93±0.2ms 8.64±0.07ms 0.97 benchmarks.NestedFrameAddNested.time_run
279M 270M 0.97 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@hombit hombit force-pushed the low-level-tutorial branch from 4e1603c to b1c6885 Compare May 9, 2024 13:18
@hombit hombit requested a review from dougbrn May 9, 2024 13:18
@hombit hombit marked this pull request as ready for review May 9, 2024 13:18
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (a196bd6) to head (950cd8d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          16       16           
  Lines         820      821    +1     
=======================================
+ Hits          800      801    +1     
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit force-pushed the low-level-tutorial branch from b1c6885 to 932db75 Compare May 9, 2024 13:21
docs/notebooks/low_level.ipynb Show resolved Hide resolved
docs/notebooks/low_level.ipynb Show resolved Hide resolved
docs/notebooks/low_level.ipynb Show resolved Hide resolved
docs/notebooks/low_level.ipynb Show resolved Hide resolved
docs/notebooks/low_level.ipynb Show resolved Hide resolved
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, the length is good as well I wouldn't suggest trimming this down at all. I went through and made a couple of grammar/sentence-flow suggestions. They're just my opinions so feel free to add or ignore as you see fit.

@hombit
Copy link
Collaborator Author

hombit commented May 9, 2024

Thank you so much, @dougbrn!

@hombit hombit merged commit 776b4c8 into main May 9, 2024
11 checks passed
@hombit hombit deleted the low-level-tutorial branch May 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants