Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper for count_nested #31

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Wrapper for count_nested #31

merged 5 commits into from
Jul 16, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jun 11, 2024

This PR resolves #7.

Action is required in Nested-Pandas before this can be merged: lincc-frameworks/nested-pandas#109. As a result, this PR will need to be released after a version increment of nested-pandas that includes the PR for this issue.

Copy link

github-actions bot commented Jun 11, 2024

Before [73e988c] After [e53bf94] Ratio Benchmark (Parameter)
222±2ms 226±3ms 1.02 benchmarks.NestedFrameReduce.time_run
219±1ms 220±1ms 1 benchmarks.NestedFrameAddNested.time_run
471±2ms 469±3ms 1 benchmarks.NestedFrameQuery.time_run
156M 154M 0.99 benchmarks.NestedFrameQuery.peakmem_run
153M 151M 0.99 benchmarks.NestedFrameReduce.peakmem_run
155M 151M 0.97 benchmarks.NestedFrameAddNested.peakmem_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from hombit July 15, 2024 23:12
@dougbrn dougbrn requested a review from hombit July 16, 2024 17:08
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dougbrn dougbrn merged commit bd4f3ce into main Jul 16, 2024
8 checks passed
@dougbrn dougbrn deleted the count_nested branch July 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap count_nested utility function
2 participants