Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LSDB notebook with science! #25

Merged
merged 1 commit into from
May 31, 2024
Merged

Update LSDB notebook with science! #25

merged 1 commit into from
May 31, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 30, 2024

It adds some stuff @dougbrn previously asked for and adds some scientific computations for the LSDB notebook.

It takes few minutes to run (1 minute on my laptop).

Requires nested-pandas 0.1.1

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Before [6af844c] <v0.1.1> After [368a084] Ratio Benchmark (Parameter)
149M 149M 1 benchmarks.NestedFrameAddNested.peakmem_run
237±1ms 237±3ms 1 benchmarks.NestedFrameAddNested.time_run
150M 150M 1 benchmarks.NestedFrameQuery.peakmem_run
147M 147M 1 benchmarks.NestedFrameReduce.peakmem_run
246±0.9ms 243±1ms 0.99 benchmarks.NestedFrameReduce.time_run
499±10ms 489±4ms 0.98 benchmarks.NestedFrameQuery.time_run

Click here to view all benchmarks.

@hombit hombit requested a review from dougbrn May 31, 2024 17:23
dougbrn
dougbrn approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I'm really excited about having a tutorial with some real analysis being shown off. I had a couple small comments, but feel free to merge after addressing them or if you don't think they are that important.

@hombit hombit merged commit 3500be8 into main May 31, 2024
8 checks passed
@hombit hombit deleted the lsdb-docs branch May 31, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbrn dougbrn dougbrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hombit @dougbrn