Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column for template version number. #36

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Mar 11, 2024

Closes #36

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 54.05%. Comparing base (bf81968) to head (ff767df).

Files Patch % Lines
src/lf_workflow_dash/github_request.py 25.00% 9 Missing ⚠️
src/lf_workflow_dash/update_dashboard.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   56.71%   54.05%   -2.67%     
==========================================
  Files           3        3              
  Lines         134      148      +14     
==========================================
+ Hits           76       80       +4     
- Misses         58       68      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from OliviaLynn March 12, 2024 11:41
Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit 462180f into main Mar 13, 2024
4 of 6 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/35/version branch March 13, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants