Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cross correlation API #15

Merged
merged 15 commits into from
Jul 19, 2024
Merged

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Jul 9, 2024

Implements the cross-correlation API. It includes a test case that computes the counts for the projected cross-correlation for two catalogs with weights (pcf_gals_weight, pcf_gals1_weight), as well as an end-to-end test that computes the estimate with the Davis-Peebles estimator. Closes #27.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Jul 9, 2024
@camposandro camposandro requested a review from smcguire-cmu July 9, 2024 21:17
Copy link

github-actions bot commented Jul 9, 2024

Before [39e15e9] After [f992e3e] Ratio Benchmark (Parameter)
2.90±1s 3.02±1s 1.04 benchmarks.time_computation
1.96k 864 0.44 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/corrgi/corrgi.py 100.00% <100.00%> (+8.33%) ⬆️
src/corrgi/estimators/estimator_factory.py 90.90% <100.00%> (+0.90%) ⬆️
src/corrgi/estimators/davis_peebles_estimator.py 92.85% <92.85%> (ø)
src/corrgi/estimators/estimator.py 96.00% <95.00%> (-0.78%) ⬇️
src/corrgi/estimators/natural_estimator.py 93.75% <50.00%> (-6.25%) ⬇️

... and 1 file with indirect coverage changes

@camposandro camposandro requested review from mardom and samotracio July 10, 2024 13:59
src/corrgi/corrgi.py Outdated Show resolved Hide resolved
@camposandro
Copy link
Contributor Author

Davis-Peebles is the only estimator in Gundam for cross-correlation (the natural estimator is not available). #25 will allow us to implement Davis-Peebles and test e2e the cross-correlation pipeline - unblocking this PR.

@camposandro camposandro marked this pull request as draft July 17, 2024 13:47
Copy link

@samotracio samotracio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me for the DP cross estimator

@camposandro camposandro marked this pull request as ready for review July 18, 2024 20:53
@camposandro camposandro merged commit b18cc97 into main Jul 19, 2024
7 checks passed
@camposandro camposandro deleted the sandro/add-cross-correlation branch July 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cross-correlation API
4 participants