-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cross correlation API #15
Conversation
Codecov ReportAttention: Patch coverage is
|
Davis-Peebles is the only estimator in Gundam for cross-correlation (the natural estimator is not available). #25 will allow us to implement Davis-Peebles and test e2e the cross-correlation pipeline - unblocking this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me for the DP cross estimator
Implements the cross-correlation API. It includes a test case that computes the counts for the projected cross-correlation for two catalogs with weights (
pcf_gals_weight
,pcf_gals1_weight
), as well as an end-to-end test that computes the estimate with the Davis-Peebles estimator. Closes #27.Code Quality