Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute projected correlation with weights #14

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Jul 9, 2024

Adds a unit test that computes the projected auto-correlation counts with weighted catalogs. Closes #22.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro requested a review from smcguire-cmu July 9, 2024 19:56
@camposandro camposandro self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Before [818ee31] After [73f9cd4] Ratio Benchmark (Parameter)
2.72±0.6s 2.13±0.5s ~0.78 benchmarks.time_computation
1.66k 2.62k 1.58 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@camposandro camposandro requested review from mardom and samotracio July 10, 2024 13:58
Copy link

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but I'm not familiar with the correctness of the tests, so may want to have someone else look over that

@camposandro camposandro merged commit 59d83c6 into main Jul 12, 2024
7 checks passed
@camposandro camposandro deleted the sandro/add-weights-to-projected-corr branch July 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap projected correlation functions
3 participants