Allow CSR and CSC matrices with no non-zero entries #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
commented
Dec 2, 2024
Comment on lines
+109
to
+114
| let max_col = if let Some(col) = cols.iter().max() { | ||
| *col | ||
| } else { | ||
| 0 | ||
| }; | ||
| let max_row = if let Some(row) = rows.last() { *row } else { 0 }; |
There was a problem hiding this comment.
This is the important change in this PR. Most other changes are due to new clippy version
mscroggs
added a commit
to bempp/bempp-rs
that referenced
this pull request
Dec 2, 2024
mscroggs
added a commit
to bempp/bempp-rs
that referenced
this pull request
Dec 9, 2024
* First working example for function space creation * working on new bindings * clippy and simplifying * fmt * more bindings * make empty CSR matrix manually (see linalg-rs/rlst#100) * new ndgrid release * is_serial * clippy * more clippy * unecesary whitespace * use nightly on ci * work on fixing CI * nightly * rust- --------- Co-authored-by: Timo Betcke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.