TF-3361 clear notification and badge number #3384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tddang-linagora
temporarily deployed
to
PR-3384
GitHub Actions
Inactive
tddang-linagora
changed the title
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3384. |
hoangdat
force-pushed
the
maintenance-v0.14.2
branch
from
83f1c02 to
dd19f3a
Compare
dab246
reviewed
Jan 2, 2025
| .where((typeName) => typeName == TypeName.emailType || typeName == TypeName.emailDelivery) | ||
| .where((typeName) => typeName == TypeName.emailDelivery) |
There was a problem hiding this comment.
Looks like you made a mistake here. _toPushNotificationAction is a function that converts to many actions, not just PushNotification. Please check it again carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Clear notifications and badge on app open
clear-notification-android.mp4
should-clear-noti-ios.mp4
Update badge number for
EmailDeliveryonlybadge_only_count_delivery_noti.mov