-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3332 Prevent refresh when switching mailbox #3368
TF-3332 Prevent refresh when switching mailbox #3368
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3368. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there a way to write a unit test for it to ensure
Email/change
is not called when switching mailboxes?
Tests added. |
test/features/thread/presentation/controller/thread_controller_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue
Should not call refresh when switching mailbox
Demo condition
Web
change-mailbox-not-call-change-get-get.mov
Mobile
change-mailbox-mobile-not-call-change-get-get.mov
Should fetch latest changes when open app
Web
Screen.Recording.2024-12-20.at.10.46.19.mov
Mobile
should.see.new.email.on.open.mobile.app.mov