Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3332 Prevent refresh when switching mailbox #3368

Conversation

tddang-linagora
Copy link
Contributor

Issue

Should not call refresh when switching mailbox

Demo condition

Web

change-mailbox-not-call-change-get-get.mov

Mobile

change-mailbox-mobile-not-call-change-get-get.mov

Should fetch latest changes when open app

Web

Screen.Recording.2024-12-20.at.10.46.19.mov

Mobile

should.see.new.email.on.open.mobile.app.mov

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3368.

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is there a way to write a unit test for it to ensure Email/change is not called when switching mailboxes?

@tddang-linagora
Copy link
Contributor Author

Is there a way to write a unit test for it to ensure Email/change is not called when switching mailboxes?

Tests added.

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoangdat hoangdat merged commit 63b1b48 into maintenance-v0.14.2 Dec 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants