Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2810 Handle crashed when no browser available for OIDC #2816

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

hoangdat
Copy link
Member

Root cause:

MaikuB/flutter_appauth#465

No browser available for OIDC

Solution:

  • parse native exception to business exception NoSuitableBrowserForOIDCException
  • show error to user

Case1: in dnslookup form

case_dnslookup.webm

Case 2: in baseUrl form

case_baseUrl.webm

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2816.

@dab246
Copy link
Member

dab246 commented Apr 23, 2024

  • Use catches with on clauses
try {
 somethingRisky()
}
on Exception catch(e) {
  doSomething(e);
}

@hoangdat hoangdat force-pushed the fix_crashed_activity_not_found branch from abadbc7 to bbef150 Compare April 23, 2024 05:23
@hoangdat hoangdat merged commit d2fdbfa into master Apr 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants