Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target f0 #18

Open
wants to merge 9 commits into
base: master-18.2.x
Choose a base branch
from
Open

Target f0 #18

wants to merge 9 commits into from

Conversation

janfietz
Copy link
Collaborator

@janfietz janfietz commented Dec 2, 2018

No description provided.

@janfietz janfietz requested a review from lilvinz December 2, 2018 12:21
lilvinz
lilvinz requested changes Dec 2, 2018
View reviewed changes
Copy link
Owner

@lilvinz lilvinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. I am glad you did it. There are just a couple of copy / paste misses which have to be resolved before merging.

src/targets/discoveryf072/bl/Makefile Outdated Show resolved Hide resolved
src/targets/discoveryf072/bl/Makefile Outdated Show resolved Hide resolved
src/targets/discoveryf072/bl/Makefile Outdated Show resolved Hide resolved
src/targets/discoveryf072/bl/Makefile Outdated Show resolved Hide resolved
src/targets/discoveryf072/bl/board.c Outdated Show resolved Hide resolved
src/targets/discoveryf072/common/board-info.mk Outdated Show resolved Hide resolved
src/targets/discoveryf072/common/board_drivers.h Outdated Show resolved Hide resolved
src/targets/discoveryf072/ft/flashtool/flash.oocd Outdated Show resolved Hide resolved
src/targets/discoveryf072/fw/Makefile Outdated Show resolved Hide resolved
src/targets/discoveryf072/fw/board.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilvinz lilvinz lilvinz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janfietz @lilvinz