Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Nouns Subgraph with Timestamp Fixes and Hash Tracking #283

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nekofar
Copy link
Contributor

@nekofar nekofar commented Nov 4, 2024

  • Set auction start time to previous auction's end time to fix incorrect auction timestamps.
  • Replaced let with const for variables that do not require reassignment.
  • Added vrgda field to the auction entity.
  • Added transaction hash field to bid entity.
  • Added transaction hash fields for proposals and votes to improve traceability.

…otes

Enhanced the schema and event handlers to store transaction hashes for proposal cancellations, executions, vetoes, and queueing, as well as for votes. This ensures traceability and improves debugging capabilities.
Include 'txHash' field in Bid schema for better traceability.
Update relevant mapping files to handle transaction hash extraction.
Introduce `vrgda` field to track VRGDA status in auctions.
improve code readability and enforce immutability where possible.
Ensure accurate recording of auction start and end times.
Ensure the auction start time correctly follows the previous auction's end time for accuracy.
This refactor improves the handling of auction settlements by restructuring the logic for loading and saving auctions and bids. It also introduces a consistent way to determine the next auction ID.
@EricDevito
Copy link
Collaborator

hey, pls provide link of working subgraph

@nekofar
Copy link
Contributor Author

nekofar commented Nov 14, 2024

hey, pls provide link of working subgraph

I’ve just deployed this branch to The Graph; check it out here:https://api.studio.thegraph.com/query/31138/lilnouns/version/latest

ensure proper handling of auctions without assigned nouns
move the setting of `settled` to follow auction initialization. This ensures correct initialization before marking the auction as settled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants