Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Provide option for Authcore social login pane position #65

Merged
merged 1 commit into from
Sep 5, 2024
Merged

✨ Provide option for Authcore social login pane position #65

merged 1 commit into from
Sep 5, 2024

Conversation

nwingt
Copy link
Member

@nwingt nwingt commented Sep 5, 2024

image

williamchong
williamchong reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be an option instead? Most cases we want user to use oauth

@nwingt nwingt changed the title 👔 Move Authcore social login to bottom ✨ Provide option for Authcore social login pane position Sep 5, 2024
@nwingt nwingt requested a review from williamchong September 5, 2024 15:32
@nwingt nwingt merged commit 369dc2b into likecoin:main Sep 5, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamchong williamchong williamchong approved these changes

@AuroraHuang22 AuroraHuang22 Awaiting requested review from AuroraHuang22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwingt @williamchong