[TAS-1816] 🚸 Display the reset password hint when hiding social options #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AuroraHuang22
commented
Jul 8, 2024
•
AuroraHuang22
commented
|
Use i18n? |
|
@nwingt updated |
nwingt
requested changes
Jul 8, 2024
src/components/authcore-dialog.tsx
Outdated
Comment on lines
37
to
40
| <FormattedMessage id="wallet_connect_hint_reset_password"/> | ||
| <span className='lk-text-like-green'> | ||
| <FormattedMessage id="wallet_connect_hint_reset_password_highlight"/> | ||
| </span> |
There was a problem hiding this comment.
Please use function as the child syntax for this https://formatjs.io/docs/react-intl/components#function-as-the-child
There was a problem hiding this comment.
nwingt
reviewed
Jul 8, 2024
src/i18n/translations/en.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "wallet_connect_header_title_open_app": "Launch App", | |||
| "wallet_connect_header_title_scan_qrcode": "Scan QR Code", | |||
| "wallet_connect_hint_approve": "Please approve the connection request in the app by clicking the button below.", | |||
| "wallet_connect_hint_reset_password": "If you can't find your login method,<span>reset your password.</span>", | |||
There was a problem hiding this comment.
Suggested change
| "wallet_connect_hint_reset_password": "If you can't find your login method,<span>reset your password.</span>", | |
| "wallet_connect_hint_reset_password": "If you can't find your login method,<span>reset your password</span>.", |
There was a problem hiding this comment.
src/i18n/translations/zh.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "wallet_connect_header_title_open_app": "啟動 App", | |||
| "wallet_connect_header_title_scan_qrcode": "掃描二維碼", | |||
| "wallet_connect_hint_approve": "請點擊以下按鈕打開 App 並批准連接請求。", | |||
| "wallet_connect_hint_reset_password": "若找不到您原先的登入方式，請<span>重設密碼</span>", | |||
There was a problem hiding this comment.
Suggested change
| "wallet_connect_hint_reset_password": "若找不到您原先的登入方式，請<span>重設密碼</span>", | |
| "wallet_connect_hint_reset_password": "若找不到您原先的登入方式，請<span>重設密碼</span>。", |
There was a problem hiding this comment.
nwingt
approved these changes
Jul 9, 2024
src/index.tsx
Outdated
| resolve(undefined); | ||
| this._events.emit('authcore_auth_closed'); | ||
| }} | ||
| isHideSocialLogin={!!(this.options.authcoreClientId === 'likecoin-app-hidesocial')} |
There was a problem hiding this comment.
Please name this likecoin-app-hidesocial and likecoin-app as some constant.
There was a problem hiding this comment.
williamchong
requested changes
Jul 15, 2024
| @@ -64,6 +64,11 @@ const SESSION_KEY = 'likecoin_wallet_connector_session'; | |||
|
|
|||
| const WC_BRIGDE = 'https://bridge.walletconnect.org'; | |||
|
|
|||
| const SOCIAL_LOGIN_OPTIONS = { | |||
| HIDE_SOCIAL: 'likecoin-app-hidesocial', | |||
| DEFAULT: 'likecoin-app', | |||
There was a problem hiding this comment.
Please also change
authcoreClientId: options.authcoreClientId || 'likecoin-app', in line 135
There was a problem hiding this comment.
AuroraHuang22
force-pushed
the
feature/reset-password-hint
branch
from
8527d81 to
40d1747
Compare
williamchong
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.