-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add docker setup and an updated README for people who want to contribute #260
[Feature]: Add docker setup and an updated README for people who want to contribute #260
Conversation
Hm, actually in retrospect, I'm not sure if it's smart to ship a complete docker setup but I think the README would be a smart idea with maybe a reference to such docker setup or alternative and which services the project needs in order to get started like php, composer, sqlite etc. |
Thanks for the PR. Changing the configuration for the database connections break the CI since the hostnames don't exist on GitHub Actions. Ideally, we would have a configuration that work in GitHub actions and on local It looks like there is no way to start a database and reach it through the Maybe the easiest solution if to pass some variables like doctrine:
dbal:
driver: pdo_mysql
host: '%env(default:127.0.0.1:file:MYSQL_HOST)%' It should fallback to the current configuration when working without |
We can try to modify
The file |
db1a705
to
16d374a
Compare
16d374a
to
e7db9a5
Compare
I made some small adjustments and now tests are passing on local environment through For some reason, Let's merge it as is. Thanks for your contribution! Update: |
Feature: Docker Setup for Testing
Motivation
I recently opened an issue (#259) and want to contribute to the project to help improve it. However, as a newcomer to Symfony and this specific project, I faced challenges getting started.
Firstly, I couldn't find a README or any documentation to guide me through the project setup. Additionally, running tests or performing other tasks seemed reliant on having PHP, Composer, MySQL, and other services installed locally, which is not an ideal practice.
To address this, I've created this branch to enhance the onboarding process for new contributors like myself.
How to Test
docker-compose up -d
to install the necessary services.docker-compose exec php-fpm bash
.composer install
./vendor/bin/phpunit
.