Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't call deprecated method getName() on doctrine platform #255

Merged
merged 1 commit into from
Jan 20, 2024
Merged

feat: don't call deprecated method getName() on doctrine platform #255

merged 1 commit into from
Jan 20, 2024

Conversation

alexislefebvre
Copy link
Collaborator

Fixes #184

Fixes #253

@alexislefebvre alexislefebvre force-pushed the feat-do-not-call-deprecated-method-getName branch from e031dd3 to 2f35785 Compare January 13, 2024 17:26
@alexislefebvre alexislefebvre mentioned this pull request Jan 13, 2024
Closed
@alexislefebvre alexislefebvre self-assigned this Jan 14, 2024
@alexislefebvre alexislefebvre added the help wanted Extra attention is needed label Jan 14, 2024
@alexislefebvre
Copy link
Collaborator Author

mongodb is missing, it must be added to keep compatibility with the cache configuration: https://github.com/liip/LiipTestFixturesBundle/blob/2.x/doc/configuration.md

@alexislefebvre alexislefebvre marked this pull request as draft January 19, 2024 12:57
@alexislefebvre alexislefebvre force-pushed the feat-do-not-call-deprecated-method-getName branch from 2f35785 to 9ca61a2 Compare January 20, 2024 13:19
@alexislefebvre alexislefebvre marked this pull request as ready for review January 20, 2024 13:20
@alexislefebvre
Copy link
Collaborator Author

I don't know how to get the platform name for Mongo, let's ignore it.

@alexislefebvre alexislefebvre force-pushed the feat-do-not-call-deprecated-method-getName branch from 9ca61a2 to be3a0cd Compare January 20, 2024 13:23
@alexislefebvre alexislefebvre merged commit f282770 into liip:2.x Jan 20, 2024
10 checks passed
@alexislefebvre alexislefebvre deleted the feat-do-not-call-deprecated-method-getName branch January 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexislefebvre alexislefebvre

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlitePlatform::getName() is deprecated AbstractDatabaseTool::getBackupService() relies on deprecated method
1 participant
@alexislefebvre